Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Node 20 -> 22 #5097

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Node 20 -> 22 #5097

wants to merge 5 commits into from

Conversation

birkskyum
Copy link
Member

@birkskyum birkskyum commented Nov 22, 2024 •
edited
Loading

22 has been the lts for 7 months now, so i think we're plenty safe to use it.

https://endoflife.date/nodejs

CI breaks because of cache of canvas in node_modules

Launch Checklist

  • Confirm your changes do not include backports from Mapbox projects (unless with compliant license) - if you are not sure about this, please ask!
  • Briefly describe the changes in this PR.
  • Link to related issues.
  • Include before/after visuals or gifs if this PR includes visual changes.
  • Write tests for all new functionality.
  • Document any changes to public APIs.
  • Post benchmark scores.
  • Add an entry to CHANGELOG.md under the ## main section.

@HarelM
Copy link
Collaborator

HarelM commented Nov 22, 2024

I like it that there's a need to change only in one place! Having said that, CI need more tender love and care...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@birkskyum @HarelM